This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-319] Reduce Scala Warning messages #11789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nswamy
reviewed
Jul 18, 2018
| @@ -89,7 +89,10 @@ object NDArray extends NDArrayBase { | |||
| output match { | |||
| case nd: NDArray => (Array(nd), Array(nd.handle)) | |||
| case ndFuncRet: NDArrayFuncReturn => (ndFuncRet.arr, ndFuncRet.arr.map(_.handle)) | |||
| case ndArr: Seq[NDArray] => (ndArr.toArray, ndArr.toArray.map(_.handle)) | |||
| case ndArr: Seq[NDArray @unchecked] => | |||
| if (ndArr.head.isInstanceOf[NDArray]) (ndArr.toArray, ndArr.toArray.map(_.handle)) | |||
There was a problem hiding this comment.
Why @unchecked and again the need to check if the head is a Instance of NDArray?
There was a problem hiding this comment.
Please check the Stackoverflow link above, the problem here is Scala cannot identify the type T of a Seq[T]. We need to break it and check inside to make sure it match our needs.
There was a problem hiding this comment.
Thank you @lanking520, would be great if you could add the link as a comment above the code.
|
Have you checked the javadoc generated? |
nswamy
approved these changes
Jul 22, 2018
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* Reduce Scala Warning messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous JavaDoc generation is causing too much warning messages. This PR is intend to reduce the numbers of issues we have as indicated in #11603.
There are three fixs:
<pre>tag onJavaDocto reduce warnings@nswamy @yzhliu @andrewfayres
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.