Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add activation information for mxnet.gluon.nn._Conv #12354

Merged
merged 1 commit into from Aug 25, 2018

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Aug 25, 2018

Description

Fix the issue #12353

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • tiny changes. The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add activation information for mxnet.gluon.nn._Conv

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Comments

szha: resolves #12353

@wkcn wkcn requested a review from szha as a code owner August 25, 2018 12:29
@szha szha merged commit 54d5777 into apache:master Aug 25, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Activation Information for mxnet.gluon.nn._Conv
2 participants