Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

support dot(vector, vector) for fp16 inputs on GPU #14102

Merged
merged 3 commits into from Feb 15, 2019
Merged

support dot(vector, vector) for fp16 inputs on GPU #14102

merged 3 commits into from Feb 15, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

As title. @ptrendx @szha @DickJC123

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Operator]

@marcoabreu marcoabreu added Operator pr-awaiting-review PR is waiting for code review labels Feb 10, 2019
ChaiBapchya
ChaiBapchya approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankkhedia
Copy link
Contributor

@szha @ptrendx @DickJC123
Could you please help review the PR?

@szha szha merged commit 549ecde into apache:master Feb 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@eric-haibin-lin @stephenrawls
support dot(vector, vector) for fp16 inputs on GPU (apache#14102)
38541a7 
* support dot(vector, vector) for fp16 inputs on GPU

* add comments

* update comments
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@eric-haibin-lin
support dot(vector, vector) for fp16 inputs on GPU (apache#14102)
613acd3 
* support dot(vector, vector) for fp16 inputs on GPU

* add comments

* update comments
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@eric-haibin-lin @drivanov
support dot(vector, vector) for fp16 inputs on GPU (apache#14102)
299f3c3 
* support dot(vector, vector) for fp16 inputs on GPU

* add comments

* update comments
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@eric-haibin-lin @vdantu
support dot(vector, vector) for fp16 inputs on GPU (apache#14102)
2e42d6a 
* support dot(vector, vector) for fp16 inputs on GPU

* add comments

* update comments
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@eric-haibin-lin
support dot(vector, vector) for fp16 inputs on GPU (apache#14102)
ae63126 
* support dot(vector, vector) for fp16 inputs on GPU

* add comments

* update comments
@ChaiBapchya ChaiBapchya mentioned this pull request Aug 16, 2019
Closed
@eric-haibin-lin eric-haibin-lin deleted the dot-fp16 branch September 2, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

Assignees
No one assigned
Labels
Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eric-haibin-lin @vandanavk @ankkhedia @ChaiBapchya @szha @marcoabreu