Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1383] Java new use of ParamObject #14645

Merged
merged 1 commit into from Apr 27, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Apr 8, 2019

Description

Previously paramObj are created in a weird way. This is a fix to that:
NDArray.new paramObj -> new paramObj

The trick is to put these param classes outside of NDArray Base and it made it accessible to the public directly under org.apache.mxnet.javaapi

@andrewfayres @zachgk @yzhliu @nswamy

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@@ -86,15 +86,15 @@ public void testGenerated(){
NDArray$ NDArray = NDArray$.MODULE$;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it didn't save the world of the method likeNDArray.<method_name> popping out

@lanking520
Copy link
Member Author

@frankfliu here as well

@Roshrini Roshrini added pr-awaiting-review PR is waiting for code review Java Label to identify Java API component labels Apr 16, 2019
@Roshrini
Copy link
Member

@frankfliu Can you help review?

@lanking520 lanking520 force-pushed the java-paramObj branch 2 times, most recently from 60aa9b5 to cc01350 Compare April 25, 2019 17:58
@lanking520 lanking520 merged commit 003800c into apache:master Apr 27, 2019
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 29, 2019
lanking520 added a commit that referenced this pull request Apr 29, 2019
* clean up submodule (#14645)

* Scala/Java Predict API fix #14756 (#14804)

* add fix in the code

* add unit test

* update comments

* add fixes to code gen
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
@lanking520 lanking520 deleted the java-paramObj branch June 21, 2019 22:11
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Java Label to identify Java API component pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants