Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix a bug in inception_inference.cpp #14674

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

champagne828
Copy link
Contributor

@champagne828 champagne828 commented Apr 11, 2019

Description

Fix a bug when use --gpu.
When i type:
./inception_inference --symbol "./model/Inception-BN-symbol.json" --params "./model/Inception-BN-0126.params" --synset "./model/synset.txt" --image "./model/dog.jpg" --gpu
there will be segmentation fault. Maybe because the data should be transfer from gpu to cpu. So i change the code from
auto array = executor->outputs[0].Copy(global_ctx);
to
auto array = executor->outputs[0].Copy(Context::cpu());
And the bug of Segmentation Fault fixed.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

fix a bug when use --gpu
@champagne828 champagne828 changed the title Update inception_inference.cpp fix a bug in inception_inference.cpp Apr 11, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM : )

@piyushghai
Copy link
Contributor

@leleamol Can you have a look here ?

@haojin2 haojin2 added the pr-awaiting-review PR is waiting for code review label Apr 12, 2019
Copy link
Contributor

@leleamol leleamol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! LGTM

@Roshrini Roshrini merged commit 8e04b88 into apache:master Apr 16, 2019
kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants