Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 #14986

Merged
merged 18 commits into from
Jul 19, 2019
Merged

[Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 #14986

merged 18 commits into from
Jul 19, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented May 17, 2019 •
edited

Description

don't merge the code after we update the GPU driver of instances running the Jenkin
Bump up the Nvidia docker to CUDA 10.1

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@perdasilva @marcoabreu

@stu1130 stu1130 changed the title Bump up the nvidia docker to CUDA 10.1 [Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 17, 2019
@stu1130 stu1130 changed the title [Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 [WIP][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 17, 2019
marcoabreu
marcoabreu suggested changes May 19, 2019
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you didn't rebase properly and are thus dismissing recent changes

ci/docker/Dockerfile.build.ubuntu_gpu_cu100 Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build.ubuntu_gpu_cu101 Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build.ubuntu_gpu_cu90 Outdated Show resolved Hide resolved
@stu1130 stu1130 changed the title [WIP][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 [DO NOT MERGE][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 20, 2019
@perdasilva
Copy link
Contributor

perdasilva commented May 20, 2019 •
edited

Please don't for get to update the NightlyTestsForBinaries. Hmmm it seems that when I updated it, I didn't update the step label . Would be great if you could update that too =)

@stu1130
Copy link
Contributor Author

stu1130 commented May 20, 2019

Good catch @perdasilva done!

@stu1130 stu1130 changed the title [DO NOT MERGE][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 [Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 20, 2019
@pinaraws
Copy link

@mxnet-label-bot add[CI, pr-awaiting-response]

@marcoabreu marcoabreu added CI pr-awaiting-response PR is reviewed and waiting for contributor to respond labels May 20, 2019
@marcoabreu
Copy link
Contributor

@perdasilva waiting for your approval here

perdasilva
perdasilva approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for your work!

@perdasilva
Copy link
Contributor

Damn. You probably also need to update: https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_nvidia.sh#L25

@perdasilva
Copy link
Contributor

@stu1130 sorry this is taking longer than it should. The problem with the sanity check has been fixed. Could you please rebase off master to get everything to green =)

@stu1130 stu1130 force-pushed the bump_up_ci_10_1 branch 2 times, most recently from 87eed59 to d28a2e0 Compare May 21, 2019 21:25
@stu1130
Copy link
Contributor Author

stu1130 commented May 22, 2019

@perdasilva done

@stu1130 stu1130 changed the title [Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 [DO NOT MERGE][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 22, 2019
@stu1130 stu1130 requested a review from szha as a code owner May 22, 2019 23:22
@stu1130 stu1130 changed the title [DO NOT MERGE][Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 [Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 May 22, 2019
@stu1130 stu1130 force-pushed the bump_up_ci_10_1 branch 3 times, most recently from 75a398b to 821e575 Compare May 23, 2019 18:20
@stu1130
Copy link
Contributor Author

stu1130 commented May 23, 2019

ping @szha @perdasilva @marcoabreu for review

perdasilva
perdasilva approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@stu1130
Copy link
Contributor Author

stu1130 commented Jun 1, 2019

@szha @marcoabreu could you merge this if it looks good to you? Thanks

@piyushghai
Copy link
Contributor

@marcoabreu Gentle ping...

@Roshrini
Copy link
Member

@marcoabreu @szha Could you take a look at this PR again? Thanks

@karan6181
Copy link
Contributor

@marcoabreu @szha Gentle ping!

@marcoabreu
Copy link
Contributor

Curious if this is gonna miss anything, considering the age of the PR. We'll see...

@marcoabreu marcoabreu merged commit 67bbf5a into apache:master Jul 19, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@stu1130
[Dependency Update] Bump up the CI Nvidia docker to CUDA 10.1 (apache…
c1d78d6 
…#14986)

* bump up the nvidia docker to CUDA 10.1

* change the func name

* change the groovy file

* clean up code & create cu101 docker file

* add cuda 10.1

* update the miss groovy

* change description

* move up the cudnn installation

* update label & func for nightly build

* update to cuda 10.1

* upgrade to build cu101mkl

* do not use nvidia docker in build static test

* fix cuda_patch_typo

* use nvidia docker

* fix the right config

* use nvidia docker and install latest cuDNN

* fix the typo

* use default cudnn
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perdasilva perdasilva perdasilva approved these changes

@marcoabreu marcoabreu marcoabreu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
CI pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stu1130 @perdasilva @pinaraws @marcoabreu @piyushghai @Roshrini @karan6181