This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Numpy bitwise_xor operator #15312
Closed
Numpy bitwise_xor operator #15312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemwx
reviewed
Jul 4, 2019
haojin2
reviewed
Jul 12, 2019
| .set_attr<nnvm::FListInputNames>("FListInputNames", | ||
| [](const NodeAttrs &attrs) { | ||
| return std::vector<std::string> {"x1", "x2" | ||
| }; |
There was a problem hiding this comment.
return std::vector<std::string> {"x1", "x2"};
haojin2
reviewed
Jul 12, 2019
| }; | ||
| }) | ||
| .set_attr<FCompute>("FCompute<cpu>", | ||
| BinaryBroadcastCompute <cpu, mshadow_op::bitwise_xor>) |
There was a problem hiding this comment.
.set_attr<FCompute>("FCompute<cpu>",
BinaryBroadcastCompute <cpu, mshadow_op::bitwise_xor>)
haojin2
force-pushed
the
numpy
branch
4 times, most recently
from
a23120e
to
07d7a94
Compare
gyshi
force-pushed
the
np_bitwise_xor
branch
2 times, most recently
from
ed4f159
to
59eb920
Compare
gyshi
requested review from
anirudh2290,
eric-haibin-lin and
szha
as code owners
|
@haojin2 ,Thanks for reviewing my Pr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[numpy bitwise_xor] (https://docs.scipy.org/doc/numpy/reference/generated/numpy.bitwise_xor.html)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@haojin2