This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Numpy hsplit #15358
Closed
Numpy hsplit #15358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank @haojin2 for guidance and reviewing! |
haojin2
force-pushed
the
numpy
branch
4 times, most recently
from
a23120e
to
07d7a94
Compare
haojin2
reviewed
Aug 15, 2019
| @@ -59,6 +59,222 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs, | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Seems like you're re-using most of the existing SplitOpForward and SplitOpBackward, maybe you could refactor the existing code to expose common SplitOpForwardImpl and SplitOpBackwardImpl and call these functions from here instead of copying the code over.
haojin2
reviewed
Aug 15, 2019
| @@ -464,5 +464,44 @@ NNVM_REGISTER_OP(_np_squeeze) | |||
| .add_argument("a", "NDArray-or-Symbol[]", "data to squeeze") | |||
| .add_arguments(SqueezeParam::__FIELDS__()); | |||
|
|
|||
| NNVM_REGISTER_OP(_npi_hsplit) | |||
| .add_alias("_npi_hsplit") | |||
There was a problem hiding this comment.
If you already registered it as _npi_hsplit then you do not need an extra _npi_hsplit alias
haojin2
reviewed
Aug 15, 2019
| .add_alias("_npi_hsplit") | ||
| .describe(R"code(Splits an array along a particular axis= 1 into multiple sub-arrays. | ||
|
|
||
| `squeeze_axis=True` removes the axis with length 1 from the shapes of the output arrays. |
There was a problem hiding this comment.
No need for .describe() here as this is an internal operator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
numpy hsplit
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@haojin2