Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy Tril (Lower triangle) operator #15696

Closed
wants to merge 3 commits into from
Closed

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Jul 30, 2019

Description

Implementation of numpy tril operator in mxnet.
The version that cherry-pick on new numpy branch, old pr -> #15508.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add tril op

Comments

Welcome @reminisce, @haojin2, and others for reviewing.

@hgt312 hgt312 requested a review from szha as a code owner July 30, 2019 05:18
@piyushghai
Copy link
Contributor

Thanks for your contributions @hgt312. @mxnet-label-bot Add [Numpy, pr-awaiting-review]

Squashed commits:
[25d38bf] finish tril
[847671a] TODO: broadcast, doc and test
@hgt312 hgt312 mentioned this pull request Aug 9, 2019
4 tasks
@hgt312 hgt312 closed this Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Numpy pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants