Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy add numpy op roll #15902

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Numpy add numpy op roll #15902

merged 2 commits into from
Sep 22, 2019

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Aug 15, 2019 •
edited
Loading

Description

(https://docs.scipy.org/doc/numpy/reference/generated/numpy.roll.html?highlight=roll#numpy.roll)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gyshi gyshi requested a review from szha as a code owner August 15, 2019 05:12
@haojin2 haojin2 self-assigned this Aug 15, 2019
@haojin2 haojin2 added the Numpy label Aug 15, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Aug 15, 2019
@gyshi gyshi force-pushed the np_op_roll branch 2 times, most recently from e18c9aa to 8e34cd8 Compare August 21, 2019 03:50
@gyshi gyshi force-pushed the np_op_roll branch 2 times, most recently from 9e2d969 to 43dfbdb Compare August 27, 2019 02:50
numpy automation moved this from In progress to Reviewer approved Sep 18, 2019
haojin2
haojin2 approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reminisce
reminisce reviewed Sep 18, 2019
View reviewed changes
src/operator/numpy/np_matrix_op.cc Show resolved Hide resolved
python/mxnet/_numpy_op_doc.py Outdated Show resolved Hide resolved
tests/python/unittest/test_numpy_op.py Show resolved Hide resolved
@haojin2 haojin2 self-requested a review September 20, 2019 03:02
@gyshi gyshi force-pushed the np_op_roll branch 8 times, most recently from 621d827 to 0f54f11 Compare September 21, 2019 09:56
@gyshi gyshi force-pushed the np_op_roll branch 2 times, most recently from 323466e to dbea372 Compare September 21, 2019 14:36
gyshi and others added 2 commits September 22, 2019 08:50
@gyshi
add numpy op roll
7f9d41d 
updata roll

address comments

fix backward and docs
@gyshi
fix docs and test fils
9a7809f
@reminisce reminisce merged commit 89cb4ad into apache:master Sep 22, 2019
numpy automation moved this from Reviewer approved to Done Sep 22, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
@gyshi @drivanov
Numpy add numpy op roll (apache#15902)
5a3055d 
* add numpy op roll

updata roll

address comments

fix backward and docs

* fix docs and test fils
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@gyshi @larroy
Numpy add numpy op roll (apache#15902)
aa3be50 
* add numpy op roll

updata roll

address comments

fix backward and docs

* fix docs and test fils
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reminisce reminisce reminisce left review comments

@szha szha Awaiting requested review from szha szha is a code owner

@haojin2 haojin2 Awaiting requested review from haojin2

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gyshi @reminisce @haojin2