This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
update cub commit for license issue #15963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
|
It seems we need to update operator code to use latest cub. |
|
How was the status now? |
|
Gentle ping @roywei , what's he current status? May I know if it's still needed in v1.7.0 release, thanks! |
|
@ciyongch Hi I don't think it's a hard requirement as the author already stated he allows us to use it. It's seem there are some code update included that breaks mxnet operator. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15569
updated cub to latest commit which the author updated license header.
cc @PatricZhao @TaoLv