Remove python2 from CI #15990

larroy · 2019-08-24T01:52:16Z

Description

This PR removes Python2 test from CI.

See:

https://lists.apache.org/list.html?dev@mxnet.apache.org:lte=1M:python2

From now on Python2 compatibility won't be tested and thus we no longer actively support Python2.

larroy · 2019-08-24T01:55:15Z

@mxnet-label-bot add [pr-work-in-progress]

larroy · 2019-08-24T01:55:24Z

@mxnet-label-bot add [ci]

marcoabreu · 2019-08-24T05:39:42Z

The community has not agreed on deprecating python2 immediately.

larroy · 2019-08-26T20:28:53Z

It's a WIP, maybe not closing?

marcoabreu · 2019-08-27T00:12:40Z

It's still a few releases down the road, so no need to put in effort at the moment. It might just send the wrong signals.

leezu · 2020-01-23T17:27:50Z

Re-open as per consensus in https://lists.apache.org/thread.html/r3a2db0f22a1680cc56804191446fef2289595798ca19fd17de1ff03e%40%3Cdev.mxnet.apache.org%3E

@larroy would you like to rebase and fix conflicts?

ci/docker/runtime_functions.sh

larroy · 2020-01-28T21:57:53Z

@mxnet-label-bot remove [pr-work-in-progress]

larroy · 2020-01-28T21:58:03Z

@mxnet-label-bot add [pr-awaiting-merge]

leezu

Submodule ps-lite is incorrectly updated as part of conflict resolution. Or is it a bug in Github UI?

leezu

Thank you

aaronmarkham · 2020-01-29T22:02:28Z

ci/docker/install/ubuntu_core.sh

@@ -21,6 +21,7 @@
 # the whole docker cache for the image

 set -ex
+perl -pi -e 's/archive.ubuntu.com/us-west-2.ec2.archive.ubuntu.com/' /etc/apt/sources.list


What's this going to do?

use the AWS mirror instead of the default ubuntu one, making docker rebuild significantly faster.

Can you make this conditional?

larroy · 2020-01-30T09:06:03Z

That will cause performance issues if run outside of CI. Maybe not replace? Also, unrelated change

Can be removed before merge. Many CI failures now that require rebuild. Can also have a conditional on being in EC2.

marcoabreu · 2020-01-30T09:46:47Z

Conditional sounds good

…his PR

Fixes regression introduced by apache#15990

* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by #17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by #16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by #15990

* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by apache#17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by apache#16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by apache#15990

* Fix CD (#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by #17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by #16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by #15990 * [CD] update pypi description, setup.py (#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <lausen@amazon.com> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>

* Fix CD (apache#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by apache#17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by apache#16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by apache#15990 * [CD] update pypi description, setup.py (apache#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <lausen@amazon.com> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>

marcoabreu added the pr-work-in-progress PR is still work in progress label Aug 24, 2019

marcoabreu added the CI label Aug 24, 2019

marcoabreu closed this Aug 24, 2019

leezu reopened this Jan 23, 2020

larroy force-pushed the py2_ci branch from c01d25f to 79d79d5 Compare January 25, 2020 01:55

larroy requested review from aaronmarkham and marcoabreu as code owners January 25, 2020 01:55

marcoabreu approved these changes Jan 25, 2020

View reviewed changes

ci/docker/runtime_functions.sh Outdated Show resolved Hide resolved

larroy force-pushed the py2_ci branch from 79d79d5 to 5e467ef Compare January 28, 2020 21:43

lanking520 removed the pr-work-in-progress PR is still work in progress label Jan 28, 2020

lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 28, 2020

leezu suggested changes Jan 28, 2020

View reviewed changes

leezu approved these changes Jan 28, 2020

View reviewed changes

zachgk approved these changes Jan 28, 2020

View reviewed changes

roywei approved these changes Jan 29, 2020

View reviewed changes

apeforest approved these changes Jan 29, 2020

View reviewed changes

eric-haibin-lin approved these changes Jan 29, 2020

View reviewed changes

eric-haibin-lin mentioned this pull request Jan 29, 2020

Drop a few py2 tests #17432

Closed

7 tasks

aaronmarkham reviewed Jan 29, 2020

View reviewed changes

larroy force-pushed the py2_ci branch from 4ed8ee4 to b3af3a2 Compare January 30, 2020 09:05

larroy and others added 6 commits January 31, 2020 02:51

remove universal

242b729

use python3 for staticbuild wheel

a80ab14

remove cython2 from Makefile

6895926

disable cython2 build, don't substitute for EC2 mirror as a part as t…

d0f9317

…his PR

Set executable bit

fd7d652

Merge branch 'master' into py2_ci

5c999ab

leezu merged commit 7caffa6 into apache:master Feb 3, 2020

szha mentioned this pull request Feb 8, 2020

Outdated mxnet nightly build wheel instructions #17537

Closed

szha added a commit to szha/mxnet that referenced this pull request Feb 8, 2020

fix CD and remove leftover from apache#15990

603113b

This was referenced Feb 8, 2020

[CD] fix CD and remove leftover from #15990 #17551

Merged

Adding scripts for nightly pip wheel builds #17550

Closed

szha added a commit to szha/mxnet that referenced this pull request Feb 11, 2020

fix CD and remove leftover from apache#15990

65565ae

szha added a commit to szha/mxnet that referenced this pull request Feb 12, 2020

fix CD and remove leftover from apache#15990

9e36cc9

szha added a commit to szha/mxnet that referenced this pull request Feb 13, 2020

fix CD and remove leftover from apache#15990

e580ffa

szha added a commit that referenced this pull request Feb 14, 2020

fix CD and remove leftover from #15990 (#17551)

1c07771

leezu mentioned this pull request Feb 17, 2020

[DISCUSSION] python2 deprecation #8703

Closed

zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020

Stop testing Python 2 on CI (apache#15990)

683c9cb

zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020

fix CD and remove leftover from apache#15990 (apache#17551)

ec84971

leezu added a commit to leezu/mxnet that referenced this pull request Mar 5, 2020

Fix cd/python/docker

3c0edc2

Fixes regression introduced by apache#15990

leezu mentioned this pull request Mar 5, 2020

Fix CD #17776

Merged

ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Apr 8, 2020

Cherrypick apache#15990

3b09876

anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020

fix CD and remove leftover from apache#15990 (apache#17551)

2f7510a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove python2 from CI #15990

Remove python2 from CI #15990

larroy commented Aug 24, 2019

larroy commented Aug 24, 2019

larroy commented Aug 24, 2019

marcoabreu commented Aug 24, 2019

larroy commented Aug 26, 2019

marcoabreu commented Aug 27, 2019

leezu commented Jan 23, 2020

larroy commented Jan 28, 2020

larroy commented Jan 28, 2020

leezu left a comment •

edited

leezu left a comment

aaronmarkham Jan 29, 2020

larroy Jan 29, 2020

marcoabreu Jan 31, 2020

larroy commented Jan 30, 2020

marcoabreu commented Jan 30, 2020

Remove python2 from CI #15990

Remove python2 from CI #15990

Conversation

larroy commented Aug 24, 2019

Description

larroy commented Aug 24, 2019

larroy commented Aug 24, 2019

marcoabreu commented Aug 24, 2019

larroy commented Aug 26, 2019

marcoabreu commented Aug 27, 2019

leezu commented Jan 23, 2020

larroy commented Jan 28, 2020

larroy commented Jan 28, 2020

leezu left a comment • edited

Choose a reason for hiding this comment

leezu left a comment

Choose a reason for hiding this comment

aaronmarkham Jan 29, 2020

Choose a reason for hiding this comment

larroy Jan 29, 2020

Choose a reason for hiding this comment

marcoabreu Jan 31, 2020

Choose a reason for hiding this comment

larroy commented Jan 30, 2020

marcoabreu commented Jan 30, 2020

leezu left a comment •

edited