Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX export: Gather #15995

Merged
merged 1 commit into from
Jan 2, 2020
Merged

ONNX export: Gather #15995

merged 1 commit into from
Jan 2, 2020

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Aug 24, 2019

Description

Support to export take operator to Gather

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Operator export
  • relevant test

Comments

@vandanavk vandanavk requested a review from szha as a code owner August 24, 2019 19:26
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review, ONNX]

@vandanavk
Copy link
Contributor Author

@Roshrini @anirudhacharya @zhreshold for review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants