Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] added check for empty params file and unknown param (not arg/aux) (#1… #16028

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

samskalicky
Copy link
Contributor

…5917)

  • added check for empty params file and unknown param (not arg/aux)

  • changed exception to warning for unknown params

  • removed unnecessary MXNetError import

  • added warning message is params is empty

  • fixed print

  • fixed formatting

  • missing paren

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

…ache#15917)

* added check for empty params file and unknown param (not arg/aux)

* changed exception to warning for unknown params

* removed unnecessary MXNetError import

* added warning message is params is empty

* fixed print

* fixed formatting

* missing paren
@samskalicky samskalicky requested a review from szha as a code owner August 28, 2019 16:59
@samskalicky
Copy link
Contributor Author

@TaoLv

@anirudh2290 anirudh2290 merged commit bf78959 into apache:v1.5.x Aug 28, 2019
@anirudh2290
Copy link
Member

Rebased and merged.

@TaoLv TaoLv changed the title added check for empty params file and unknown param (not arg/aux) (#1… [v1.5.x] added check for empty params file and unknown param (not arg/aux) (#1… Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants