This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix omp fork race conditions and assert issue #17039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for: #14979
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Comments
When forking, sometimes mxnet can hook its fork handler before openmp's, depending upon static startup order as well as variables such as whether OMP_NUM_THREADS is set. This is mitigated by forcing an OMP call before mxnet hooks a fork handler as well as first-thing after forking as the child. This avoids two scenarios:
A considerable amount of multithreading is done by mxnext both during static init as ell as in atfork() handlers, and we may wish to change this over time. Due to the non-deterministic startup order of static init (and thus sometimes fork handling), it can cause unpredictable results.
Build omp in release mode to stop harmless assert. Comment notes that assert is harmless and represents a variable that fails to get set to null in their atfork_child handler (they set other similar variables to to null). The variable is set to NULL in the next line of code.