Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix flaky test_gluon_data_vision.test_random_transforms #17492

Closed

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jan 30, 2020

Description

Fix #17369

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix flakiness

Comments

Tested with 1000 trials

@haojin2 haojin2 added the Numpy label Jan 30, 2020
@haojin2 haojin2 self-assigned this Jan 30, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Jan 30, 2020
@haojin2 haojin2 added this to To Do in Tests Improvement via automation Jan 30, 2020
@haojin2 haojin2 removed this from In progress in numpy Jan 30, 2020
@haojin2
Copy link
Contributor Author

haojin2 commented Feb 3, 2020

@D-Roberts Oops, I think I just merged a PR that led to a conflict now, would you please resolve the conflict? Thanks!

@haojin2 haojin2 force-pushed the fix_flaky_test_random_transforms branch from a68b246 to 2934445 Compare March 2, 2020 19:06
@haojin2
Copy link
Contributor Author

haojin2 commented Apr 24, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, website, centos-gpu, miscellaneous, windows-cpu, unix-cpu, clang, sanity, windows-gpu, centos-cpu, edge]

@szha
Copy link
Member

szha commented Jul 29, 2020

this test doesn't seem flaky anymore.

@szha szha closed this Jul 29, 2020
Tests Improvement automation moved this from To Do to Done Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

flaky test: test_gluon_data_vision.test_random_transforms
3 participants