Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update website, README and NEWS with 1.6.0 #17658

Merged
merged 7 commits into from
Mar 3, 2020

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Feb 22, 2020

Description

Update website, README and NEWS with 1.6.0 links.

@leezu
Copy link
Contributor

leezu commented Feb 22, 2020

@szha what is the status / plan for versioned website?
Currently we don't have a website for MXNet 1.6

@ptrendx ptrendx changed the title [WIP] Update website, README and NEWS with 1.6.0 Update website, README and NEWS with 1.6.0 Feb 27, 2020
@ptrendx
Copy link
Member Author

ptrendx commented Feb 27, 2020

Ok, I believe it should be ready for review.

I updated:

  • README,
  • NEWS.md (including fixing multiple not working links there)
  • Getting started webpage

@szha @aaronmarkham @ThomasDelteil @roywei Please review

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEWS and README updates look good to me

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace the "v1-5-0" string in all md files with "v1-5-1". See #17725

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get Started for Windows is not covered in this PR. So users visiting https://mxnet.apache.org/get_started?version=v1.6.0&platform=windows&language=python&processor=gpu&environ=pip& would see empty content.

Could you include a paragraph about pip package for 1.6.0 not being available yet? That will be better than showing blank instructions.

@ptrendx
Copy link
Member Author

ptrendx commented Feb 29, 2020

I was wondering about this 1-5-0 too, but (at least on chrome, I did not check other browsers) it seems to work ok.

@ptrendx
Copy link
Member Author

ptrendx commented Feb 29, 2020

Actually I see now what you are talking about. Yes, that needs to be changed.

@ptrendx
Copy link
Member Author

ptrendx commented Feb 29, 2020

Get Started for Windows is not covered in this PR. So users visiting https://mxnet.apache.org/get_started?version=v1.6.0&platform=windows&language=python&processor=gpu&environ=pip& would see empty content.

Could you include a paragraph about pip package for 1.6.0 not being available yet? That will be better than showing blank instructions.

What is the timeline for getting Windows pip packages ready?

@leezu
Copy link
Contributor

leezu commented Mar 1, 2020

What is the timeline for getting Windows pip packages ready?

They need to be built manually. @yajiedesign was helping with that.
@yajiedesign do you have an ETA?

@leezu
Copy link
Contributor

leezu commented Mar 1, 2020

Retriggered windows gpu pipeline

@ptrendx
Copy link
Member Author

ptrendx commented Mar 3, 2020

Ok, since we did not hear from @yajiedesign about the ETA of Windows pip wheels yet, I will go ahead and change the Windows text to say that those are not yet available, according to suggestion from @leezu.

@ptrendx
Copy link
Member Author

ptrendx commented Mar 3, 2020

@leezu Could you review again?

@leezu leezu merged commit 2abd225 into apache:master Mar 3, 2020
@ptrendx
Copy link
Member Author

ptrendx commented Mar 3, 2020

@leezu Do you know when will the website refresh? I want to send the announcement email once that happens.

@leezu
Copy link
Contributor

leezu commented Mar 3, 2020

I haven't verified it, but my assumption is that you can check the status of the jenkins jobs at https://github.com/apache/incubator-mxnet/commits/master
One of them should publish the website?

@leezu
Copy link
Contributor

leezu commented Mar 3, 2020

MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* Update NEWS.md

* Actually update NEWS.md

* Fix typo

* Update Get started webpage

* Add the pip packages graphic

* Adding a not that Windows pip packages are not available yet.
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* Update NEWS.md

* Actually update NEWS.md

* Fix typo

* Update Get started webpage

* Add the pip packages graphic

* Adding a not that Windows pip packages are not available yet.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants