This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change 1 (Fix for rmsprop_update and rmsprop_alex_update)
After merging PR #17449 and #17400
refactor of optimizer was incomplete due to both PRs not knowing changes made by each other.
While #17449 added set of variables for large tensor, #17400 refactored 2 variables from gamma1 gamma2 to rho and momentum
Fixing that conflict here
Change 2 (Fix for BatchNorm)
Upon running entire opperf suite for CUDA=ON, CUDNN=ON, it was found BatchNorm fails here
Change 3 Fix for lamb_update_*
wd parameter was incorrectly omitted from default_params
Added it back
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.