Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix npx.softmax for 0-sized inputs #17796

Closed
wants to merge 1 commit into from

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Mar 9, 2020

Description

Fix #17792

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix npx.softmax on zero-sized inputs
  • Extra unit tests for 0-sized inputs

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Mar 9, 2020
@haojin2 haojin2 requested a review from reminisce March 9, 2020 21:50
@haojin2 haojin2 self-assigned this Mar 9, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Mar 9, 2020
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 force-pushed the softmax_0_size branch 2 times, most recently from 03307eb to c45006e Compare March 13, 2020 22:37
@haojin2
Copy link
Contributor Author

haojin2 commented Mar 25, 2020

@mxnet-bot run ci [unix-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-cpu]

@leezu
Copy link
Contributor

leezu commented Apr 22, 2020

@mxnet-bot run ci [unix-cpu, windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, windows-gpu, windows-cpu]

@haojin2 haojin2 closed this Apr 22, 2020
numpy automation moved this from In progress to Done Apr 22, 2020
@haojin2 haojin2 deleted the softmax_0_size branch April 23, 2020 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

Softmax raises exception for zero-size tensor on GPU
4 participants