Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[NumPy] Fix np flip when axis input contains negative number #17880

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Mar 20, 2020

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix and extra error message
  • Extra test case

Comments

@xidulu

@haojin2 haojin2 added the Numpy label Mar 20, 2020
@haojin2 haojin2 self-assigned this Mar 20, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Mar 20, 2020
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thx for your contribution : )

@haojin2
Copy link
Contributor Author

haojin2 commented Mar 25, 2020

@mxnet-bot run ci [centos-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, windows-gpu]

@haojin2
Copy link
Contributor Author

haojin2 commented Apr 9, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@haojin2 haojin2 merged commit d8c7293 into apache:master Apr 10, 2020
numpy automation moved this from In progress to Done Apr 10, 2020
@haojin2 haojin2 deleted the fix_np_flip branch April 10, 2020 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants