Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

32 to 64 bit toolchain for windows-gpu build #17916

Closed
wants to merge 12 commits into from

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Mar 26, 2020

Changes

  1. Switch from 32 to 64bit toolchain
    Trying out @snnn suggestion :
    [ONNX export] Fixing spatial export for batchnorm #17711 (comment)

  2. Update dmlc-core to include the latest master (fix VS 2019 in dmlc)

  3. Switch from 2015 to 2019 VS

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
Once your PR is ready for CI checks, invoke the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, website, centos-cpu, windows-cpu, unix-gpu, centos-gpu, clang, sanity, windows-gpu, unix-cpu, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, windows-cpu]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, windows-cpu]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, windows-gpu]

@josephevans
Copy link
Contributor

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, windows-gpu]

@marcoabreu
Copy link
Contributor

It seems like you are using the CI to develop a solution instead of verifying it. Would it make more sense to spin up a VM and develop the changes in there? Our setup is made so it so it can be reproduced on a VM, so I'd rather recommend that than trial and error in CI - especially considering the cost focus of your team at the moment.

@ChaiBapchya
Copy link
Contributor Author

Yes. We're testing on VM and making changes @vexilligera can confirm.

It passes on Windows VM but fails on the CI for some reason (for eg x86_64 bat file change to x64). So had to push it here and check on CI to verify if it is working or not.

Agreed its an abuse of CI to check it but because of above mentioned reason I did that.

@ChaiBapchya
Copy link
Contributor Author

Switching the toolchain from 32bit to 64bit alone doesnt fix the windows-gpu build issue.
Closing in favor of #17808 which has all the required fixes for windows-gpu build issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants