Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Website 2.0] Nightly Build for v2.x (master) #17957

Merged
merged 2 commits into from
Apr 10, 2020
Merged

[Website 2.0] Nightly Build for v2.x (master) #17957

merged 2 commits into from
Apr 10, 2020

Conversation

connorgoggins
Copy link
Contributor

@connorgoggins connorgoggins commented Apr 1, 2020 •
edited

Description

To add a nightly build Jenkins pipeline for v2.x (master), we need to create a new Jenkinsfile capable of building all the components without the "Publish" step.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • A ci/jenkins/Jenkinsfile_website_nightly

Comments

Tested successfully on Jenkins dev instance (see build output here).

Pipeline is available here.

@mxnet-bot
Copy link

Hey @connorgoggins , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, sanity, windows-gpu, edge, clang, unix-gpu, windows-cpu, centos-gpu, centos-cpu, website, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Apr 1, 2020
@connorgoggins connorgoggins mentioned this pull request Apr 1, 2020
Merged
3 tasks
@connorgoggins
Copy link
Contributor Author

@mxnet-bot run ci [continuous build]

@mxnet-bot
Copy link

None of the jobs entered are supported.
Jobs entered by user: [continuous build]
CI supported Jobs: [windows-gpu, sanity, clang, centos-cpu, edge, miscellaneous, unix-cpu, unix-gpu, website, windows-cpu, centos-gpu]

@connorgoggins
Copy link
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, sanity, clang, centos-cpu, edge, miscellaneous, unix-cpu, unix-gpu, website, windows-cpu, centos-gpu]

@connorgoggins connorgoggins force-pushed the website_nightly_master branch 2 times, most recently from f3f8176 to 22ad034 Compare April 6, 2020 16:38
aaronmarkham
aaronmarkham approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeep-krishnamurthy
Copy link
Contributor

@ChaiBapchya - Can you please give a review here?

@szha szha merged commit a6fef3f into apache:master Apr 10, 2020
@szha
Copy link
Member

szha commented Apr 10, 2020

oops didn't see the comment until after the merge @sandeep-krishnamurthy. @ChaiBapchya feel free to leave any comment or let me know if revert is necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@connorgoggins @mxnet-bot @sandeep-krishnamurthy @szha @aaronmarkham @lanking520