Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Pass args fix2 #18236

Merged
merged 6 commits into from May 29, 2020
Merged

[1.x] Pass args fix2 #18236

merged 6 commits into from May 29, 2020

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented May 4, 2020

Description

Cherry pick #18232 (#18237 in v1.7.x branch) and #18177

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@samskalicky samskalicky requested a review from szha as a code owner May 4, 2020 22:18
@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-cpu, windows-gpu, centos-gpu, edge, sanity, website, clang, unix-gpu, unix-cpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky mentioned this pull request May 4, 2020
7 tasks
@samskalicky samskalicky changed the title [1.7] Pass args fix2 [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues May 5, 2020
@ChaiBapchya
Copy link
Contributor

@ciyongch
Copy link
Contributor

HI @samskalicky , please help to rebase to remove the conflicts :)

@samskalicky
Copy link
Contributor Author

@ciyongch thanks for the reminder, I merged

@samskalicky
Copy link
Contributor Author

@mxnet-bot run ci [edge, windows-gpu, centos-cpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, centos-cpu, windows-gpu, centos-gpu]

@samskalicky
Copy link
Contributor Author

@ciyongch looks like the CI is currently broken for 1.x per @leezu

does this block the 1.7 release?

@ciyongch
Copy link
Contributor

Hi @samskalicky , there's several PRs struggling with the CI failure so far. @waytrue17 is working on the fix of edge job (NVidia Jetson / ARMv8). While for the centos-gpu and centos-cpu jobs in this PR failed for Cannot open: https://centos7.iuscommunity.org/ius-release.rpm. Skipping., can you help to take a check? thanks!

@samskalicky
Copy link
Contributor Author

According to iusrepo/announce#18 we need to change the path we use to install python in ci/docker/install/centos7_python.sh from https://centos7.iuscommunity.org/ius-release.rpm to https://repo.ius.io/ius-release-el7.rpm. Ive updated it, lets see if it passes CI now.

@samskalicky samskalicky changed the title [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues [1.7] Pass args fix2 + Fix centos7 ius-release.rpm May 26, 2020
@samskalicky samskalicky changed the title [1.7] Pass args fix2 + Fix centos7 ius-release.rpm [1.7] Pass args fix2 May 26, 2020
@leezu
Copy link
Contributor

leezu commented May 27, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ciyongch
Copy link
Contributor

Hi @samskalicky , probably rename the title to [1.x] instead of [1.7] for this PR? Thanks.

@samskalicky samskalicky changed the title [1.7] Pass args fix2 [1.x] Pass args fix2 May 27, 2020
@samskalicky
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge]

@ciyongch I updated the title, @leezu ready to merge!

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 27, 2020
@apeforest apeforest merged commit ac3e71b into apache:v1.x May 29, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
* fixed overwrite of args/aux variables

* fixed spacing

* Merged apache#18177

* updated python RPM URL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants