Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Revert PR 17767 for fixing GPU memory usage regression (#18283) #18309

Merged
merged 1 commit into from May 29, 2020
Merged

[1.x] Revert PR 17767 for fixing GPU memory usage regression (#18283) #18309

merged 1 commit into from May 29, 2020

Conversation

rondogency
Copy link
Contributor

This reverts commit 5542d03.

  • add license to reverted file

This revert has been patched into 2.0, need to cherry-pick to 1.x and 1.7

@ciyongch

@rondogency
Revert PR 17767 for fixing GPU memory usage regression (apache#18283)
ac4fce1 
* Revert "Fix and optimize handling of vectorized memory accesses (apache#17767)"

This reverts commit 5542d03.

* add license to reverted file
@mxnet-bot
Copy link

Hey @rondogency , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, edge, sanity, miscellaneous, clang, windows-gpu, unix-gpu, centos-cpu, website, centos-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor

Hi @rondogency , can you help to create another PR for v1.7.x as well, as I don't have the permission to do the cherry-pick. Thanks!
@TaoLv @pengzhao-intel please help to merge once it pass the CI.

@rondogency
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@rondogency rondogency mentioned this pull request May 14, 2020
Merged
@rondogency
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ChaiBapchya
Copy link
Contributor

@rondogency can we rename the title with [1.x] pre-pend to the existing name? For easier access. Thanks

@szha szha requested a review from ptrendx May 26, 2020 18:13
@ChaiBapchya
Copy link
Contributor

Since #18375 is merged, edge pipeline should be unblocked
@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@rondogency rondogency changed the title Revert PR 17767 for fixing GPU memory usage regression (#18283) [1.x] Revert PR 17767 for fixing GPU memory usage regression (#18283) May 26, 2020
@rondogency
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@rondogency
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@eric-haibin-lin eric-haibin-lin merged commit d621e50 into apache:v1.x May 29, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
@rondogency @ChaiBapchya
Revert PR 17767 for fixing GPU memory usage regression (apache#18283) (…
47ea684 
…apache#18309)

* Revert "Fix and optimize handling of vectorized memory accesses (apache#17767)"

This reverts commit 5542d03.

* add license to reverted file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

@ptrendx ptrendx ptrendx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rondogency @mxnet-bot @ciyongch @ChaiBapchya @eric-haibin-lin @ptrendx