Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Website 2.0] Artifact URL Adjustment #18340

Merged
merged 4 commits into from
May 20, 2020
Merged

[Website 2.0] Artifact URL Adjustment #18340

merged 4 commits into from
May 20, 2020

Conversation

connorgoggins
Copy link
Contributor

@connorgoggins connorgoggins commented May 16, 2020 •
edited

Description

This PR moves static artifacts to MXNet website artifacts public bucket.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • M docs/static_site/Makefile

Comments

These changes have been tested with a complete website build on Jenkins dev and local hosting. All functionality remains the same.

@sandeep-krishnamurthy @aaronmarkham @ys2843

@mxnet-bot
Copy link

Hey @connorgoggins , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, sanity, centos-cpu, centos-gpu, unix-cpu, website, windows-gpu, clang, miscellaneous, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label May 16, 2020
@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [Website]

aaronmarkham
aaronmarkham reviewed May 16, 2020
View reviewed changes
docs/static_site/Makefile
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
wget https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the macosx folder for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When ZIP artifacts are compiled on a Mac (as the current artifact is), the __MACOSX folder is autogenerated when they are extracted. If future versions of the artifact are compiled using a different OS, this won't cause any problems since the rm -rf command will pass even if the specified folder doesn't exist.

@aaronmarkham aaronmarkham merged commit 67ae544 into apache:master May 20, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@connorgoggins @AntiZpvoh
[Website 2.0] Artifact URL Adjustment (apache#18340)
71d004b 
* Testing new S3 bucket without publish step

* Adding publish step & restricted nodes for prod

* Drop restricted on primary node for testing'

* Revert to restricted nodes with publishing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@ys2843 ys2843 ys2843 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@connorgoggins @mxnet-bot @aaronmarkham @ys2843 @lanking520