Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Cherry-pick Fix mxnet-native and Docker CD pipelines (#17784) #18573

Closed
wants to merge 1 commit into from

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Jun 16, 2020

  • Fix Jenkinsfile CD pipeline for mxnet-native
  • Fix cd/python/docker/python_images.sh

This fixes CD Python docker images pipeline for v1.x branch
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job-1.x/detail/mxnet-cd-release-job-1.x/309/pipeline

* Fix Jenkinsfile CD pipeline for mxnet-native

* Fix cd/python/docker/python_images.sh
@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, website, unix-cpu, sanity, windows-cpu, clang, unix-gpu, windows-gpu, edge, centos-cpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10
Copy link
Contributor Author

mseth10 commented Jun 16, 2020

We still need to check for this issue:
#18465 (comment)

@ChaiBapchya
Copy link
Contributor

So does this mean the PR is incomplete? like are there more additions to be done?
I can see few jobs red/yellow [fail] in past 2 days.

@mseth10
Copy link
Contributor Author

mseth10 commented Jun 17, 2020

No, this PR is complete. We are just cherry-picking a PR from master here. This should fix CD python docker images pipeline for 1.x branch.
Once fixed, docker images will be published as they are supposed to. The race condition mentioned in the comment might be a concern then. It’s not related to this PR, but needs to be looked into separately.

@mseth10 mseth10 closed this Jul 10, 2020
@mseth10 mseth10 deleted the cherry-pick-1.x branch July 10, 2020 20:03
@ChaiBapchya
Copy link
Contributor

Why was this closed? Is the issue fixed w/o this cherry-pick?

@mseth10 mseth10 restored the cherry-pick-1.x branch July 10, 2020 21:52
@mseth10
Copy link
Contributor Author

mseth10 commented Jul 10, 2020

Thanks for pointing out. I deleted the branch by mistake. Restoring it now.

@mseth10 mseth10 reopened this Jul 10, 2020
@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 26, 2020
@mseth10
Copy link
Contributor Author

mseth10 commented Nov 14, 2020

Closing this in favor of #19411

@mseth10 mseth10 closed this Nov 14, 2020
@mseth10 mseth10 deleted the cherry-pick-1.x branch November 14, 2020 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants