Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x]Add constraint to numpy version to <1.19.0 in CI #18651

Merged
merged 1 commit into from Jul 1, 2020

Conversation

ciyongch
Copy link
Contributor

@ciyongch ciyongch commented Jul 1, 2020

Description

As reported in #18600, there're some failures related to numpy operators with numpy 1.19.0 (which was released on Jun 21, 2020). Since numpy doesn't follow semantic versioning, and it requires more integration/functionality tests to make sure MXNet is compatible to the latest numpy version. Before all this works are completed, this PR adds constraint to numpy version < 1.19.0 to enable CI pipeline.

@szha @TaoLv @leezu

@mxnet-bot
Copy link

Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-gpu, unix-cpu, windows-cpu, clang, centos-gpu, website, unix-gpu, centos-cpu, sanity, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with restricting this in the CI, but I think we do need to ensure that MXNet 1.7 works well with Numpy 1.19 before it can be released.

@leezu leezu merged commit 16144ff into apache:v1.x Jul 1, 2020
@ciyongch ciyongch deleted the fix/ci_numpy_1.x branch July 2, 2020 01:47
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants