Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Backport 1.x] Update to thrust 1.9.8 on Windows (#18218) #18977

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

[Backport 1.x] Update to thrust 1.9.8 on Windows (#18218) #18977

wants to merge 2 commits into from

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Aug 21, 2020 •
edited

Description

The PR mitigates the build failure due to NVCC bug for building windows artifact.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@leezu

@mxnet-bot
Copy link

Hey @stu1130 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-gpu, unix-gpu, sanity, edge, unix-cpu, miscellaneous, website, windows-gpu, windows-cpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky mentioned this pull request Aug 21, 2020
Open
@szha szha added this to the v1.8.0 milestone Aug 23, 2020
@leezu @stu1130
Update to thrust 1.9.8 on Windows (apache#18218)
1de0b66 
* Update to thrust 1.9.8 on Windows

* Remove debug logic
@leezu @stu1130
Re-enable build retries on MSVC (apache#18230)
809b248 
Updating thrust alone did not help. Similar issues (though less often) still
occur with updated thrust, and also with nvidia cub. Tracked upstream at
NVIDIA/thrust#1090
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stu1130 @mxnet-bot @szha @leezu