Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport Improve environment variable handling in unittests (#18424) #19173

Merged
merged 3 commits into from
Sep 18, 2020

Conversation

DickJC123
Copy link
Contributor

Description

This is a backport to v1.x of the PR #18424. The original PR built on the work of @larroy, and introduced the with environment(): context and @with_environment() decorator. The PR replaced the ad hoc manipulation of environment variables in unittests and solved the 'read-only env var state' problem of Windows.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @DickJC123 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-cpu, clang, sanity, unix-gpu, edge, miscellaneous, windows-gpu, centos-gpu, website, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu merged commit 5079c35 into apache:v1.x Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants