Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.8.x] fix for MX_ERROR_MSG namespace #19756

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Jan 15, 2021

Description

When used out side of the mxnet::ext namespace the MX_ERROR_MSG macro causes errors like:

/home/ubuntu/NeoMXNet/3rdparty/mxnet/include/mxnet/lib_api.h:245:22: error: ‘MXerrorMsgs’ has not been declared
 #define MX_ERROR_MSG MXerrorMsgs::get()->add(__FILE__, __LINE__)
                      ^

The fix is to change:
https://github.com/apache/incubator-mxnet/blob/636b6e2a7482a7c242a7f5bbc5e694243e5ceae3/include/mxnet/lib_api.h#L245
to:

#define MX_ERROR_MSG mxnet::ext::MXerrorMsgs::get()->add(__FILE__, __LINE__)

So that any usage outside of the namespace will get the scope.

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-gpu, centos-cpu, unix-cpu, edge, miscellaneous, sanity, clang, unix-gpu, windows-cpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 15, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 15, 2021
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samskalicky samskalicky merged commit 2fc0706 into apache:v1.8.x Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants