Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[master] Bring dnnl_readme.md on master up-to-date #20670

Merged
merged 7 commits into from Oct 30, 2021
Merged

[master] Bring dnnl_readme.md on master up-to-date #20670

merged 7 commits into from Oct 30, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Oct 14, 2021 •
edited

Description

Many things have changed in the framework since the last update of the dnnl_readme.md file. Part of the changes is removal of MXNET_SUBGRAPH_BACKEND flag from documentation as it is not used on master branch anymore.

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-gpu, centos-cpu, unix-gpu, miscellaneous, clang, windows-cpu, sanity, edge, unix-cpu, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 14, 2021
@bartekkuncer
Copy link
Contributor Author

@anko-intel @bgawrych Please review.

@szha
Copy link
Member

szha commented Oct 14, 2021

Just to make sure the context is available in the future, could you add explanation to this PR?

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 14, 2021
@bartekkuncer
Copy link
Contributor Author

Just to make sure the context is available in the future, could you add explanation to this PR?

@szha Sure.

@bartekkuncer bartekkuncer marked this pull request as draft October 14, 2021 18:44
@bartekkuncer bartekkuncer changed the title [master] Remove MXNET_SUBGRAPH_BACKEND environment variable [master] Bring dnnl_readme.md on master up-to-date Oct 19, 2021
@bartekkuncer bartekkuncer marked this pull request as ready for review October 19, 2021 12:09
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 19, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 25, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 25, 2021
@bartekkuncer
Copy link
Contributor Author

@szha Please help with the merge.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Oct 26, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@szha
Copy link
Member

szha commented Oct 27, 2021

@mxnet-bot run ci [unix-gpu, centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 27, 2021
@szha szha merged commit 0eeaa49 into apache:master Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgawrych bgawrych bgawrych left review comments

@anko-intel anko-intel anko-intel approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bartekkuncer @mxnet-bot @szha @anko-intel @bgawrych @mseth10