Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add quantization API doc and oneDNN to migration guide #20813

Merged
merged 8 commits into from Feb 5, 2022
Merged

Add quantization API doc and oneDNN to migration guide #20813

merged 8 commits into from Feb 5, 2022

Conversation

bgawrych
Copy link
Contributor

Description

Migration guide:
image

Quantization API:
image

Bartlomiej Gawrych and others added 6 commits December 14, 2021 13:56
Add quantization API doc
9a6b8b1
Add oneDNN info to migration guide
2e81c7b
@bgawrych @bartekkuncer
Apply suggestions from code review
ce66aeb 
Co-authored-by: bartekkuncer <bartosz.kuncer@intel.com>
Apply review
fcc1cc1
@bgawrych @bartekkuncer
Apply suggestions from code review
b243346 
Co-authored-by: bartekkuncer <bartosz.kuncer@intel.com>
@bgawrych @anko-intel
Apply suggestions from code review
c61b211 
Co-authored-by: Andrzej Kotłowski <Andrzej.Kotlowski@intel.com>
@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, edge, unix-gpu, centos-cpu, miscellaneous, unix-cpu, clang, sanity, windows-gpu, windows-cpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 10, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 11, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 12, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 12, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mseth10 mseth10 added the pr-awaiting-review PR is waiting for code review label Jan 18, 2022
bartekkuncer
bartekkuncer suggested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add a dot at the end of the sentence in python/mxnet/contrib/quantization.py:166.

docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
python/mxnet/contrib/quantization.py Outdated Show resolved Hide resolved
python/mxnet/contrib/quantization.py Outdated Show resolved Hide resolved
python/mxnet/contrib/quantization.py Outdated Show resolved Hide resolved
@bgawrych @bartekkuncer
Apply suggestions from code review
f697377 
Co-authored-by: bartekkuncer <bartosz.kuncer@intel.com>
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 27, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 28, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 31, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 31, 2022
bartekkuncer
bartekkuncer approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well written.

@szha szha merged commit 1cb4d1d into apache:master Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@agrabows agrabows agrabows approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bgawrych @mxnet-bot @bartekkuncer @agrabows @szha @mseth10