This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] Improve compile/use of nvmlDeviceGetComputeRunningProcesses() #20887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is filed to solve the issue reported in #20467 as well as #20863. For fixing this issue, an initial solution was provided in #20499 by @khaotik. This PR, with a fix from @DickJC123, adds more compilation robustness across drivers and both settings of the NVML_NO_UNVERSIONED_FUNC_DEFS cmake flag.
In this PR, we would like to merge these two solutions and find a general solution that avoids compilation errors no matter which signature of the nvmlDeviceGetComputeRunningProcesses() function is enabled in the code.
Checklist
Essentials
Dick Carter finished coding on this PR
All changes are fully tested by Guanxin Li
Code is well-documented
Changes
The change reduce the possibly versioned variant of nvmlProcessInfo_t* expected
as the 3rd arg of nvmlDeviceGetComputeRunningProcesses().
Comments
This change is a backward incompatible change, without this change, mxnet can't be compiled in cuda11 450.x driver