Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove first_quantization_pass FC property #20908

Merged
merged 1 commit into from Mar 4, 2022
Merged

Remove first_quantization_pass FC property #20908

merged 1 commit into from Mar 4, 2022

Conversation

anko-intel
Copy link
Contributor

@anko-intel anko-intel commented Feb 22, 2022 •
edited

Description

It turns out that first_quantization_pass FC property is not needed any longer. fc_param.dnnl_param.quantized is enough to distinguish phases of quantization

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, miscellaneous, clang, centos-cpu, website, sanity, unix-cpu, edge, unix-gpu, centos-gpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 22, 2022
@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@anko-intel
Remove first_quantization_pass FC property
61a88b0 
It turns out that first_quantization_pass FC property is not needed
any longer
@anko-intel anko-intel force-pushed the anko_remove_first_quantization_pass branch from 3558f4a to 61a88b0 Compare March 3, 2022 09:47
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2022
@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2022
DominikaJedynak
DominikaJedynak approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@DominikaJedynak DominikaJedynak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgawrych bgawrych merged commit 6c2b3dc into apache:master Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgawrych bgawrych bgawrych approved these changes

@DominikaJedynak DominikaJedynak DominikaJedynak approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anko-intel @mxnet-bot @bgawrych @DominikaJedynak @mseth10