This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Increase the tolerance #7926
Closed
Increase the tolerance #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
reviewed
Sep 17, 2017
|
|
||
| test = mx.symbol.BatchNorm(data, fix_gamma=False, use_global_stats=True, axis=chaxis) | ||
| check_numeric_gradient(test, in_location, xmean_std, numeric_eps=1e-2, rtol=0.2, atol=0.01) | ||
| check_numeric_gradient(test, in_location, xmean_std, numeric_eps=1e-2, rtol=0.2, atol=1e-4) |
|
Is this newly failing? That's a pretty bad tolerance. Are the c++ unit tests being run? Do they pass? |
|
What I mean is, did it just recently start failing or it's been failing periodically? I didn't see it on the list of failing tests before. What's the failure rate now? Are the cpp unit tests running? Are they passing? Batch norm operator is tested exhaustingly in the cpp unit tests. |
|
@cjolivier01 I have seen this failing since last week >75%, we are not running CPP test :( |
|
Was it failing before last week? Because if it wans t, it's not the fault
of the test. Not falling without 0.01 error is a problem.
…On Sun, Sep 17, 2017 at 10:30 PM Gautam Kumar ***@***.***> wrote:
@cjolivier01 <https://github.com/cjolivier01> I have seen this failing
since last week >75%, we are not running CPP test :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7926 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKts_U8ql35ePx7kMUzR7cavmHY5cqI1ks5sjgADgaJpZM4PaUjN>
.
|
|
@cjolivier01 I saw the failure since last two weeks, haven't noticed before. |
|
The test has been failing continuously here is another instance today |
|
Whops wrong test fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@piiswrong @nswamy @cjolivier01