Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix computation of num_inputs for Python API create_operator_entry fo… #7977

Merged
merged 1 commit into from Sep 21, 2017

Conversation

fhieber
Copy link
Contributor

@fhieber fhieber commented Sep 21, 2017

…r custom operators with 0 arguments.

This is the same change as in #7967 but against v0.11.0 branch.

Will this be built to Pypi package index automatically?

@szha
Copy link
Member

szha commented Sep 21, 2017

We will need to manually tag a release to get it built and released on pypi.

@fhieber
Copy link
Contributor Author

fhieber commented Sep 21, 2017

We'd appreciate this a lot :)

@piiswrong piiswrong merged commit 77c5079 into apache:v0.11.0 Sep 21, 2017
@fhieber fhieber deleted the custom_op_shape_fix_v.11.0 branch September 22, 2017 06:45
@fhieber
Copy link
Contributor Author

fhieber commented Sep 22, 2017

@szha @piiswrong What's the process to get this into a pypi release or who should we contact for this?

@szha
Copy link
Member

szha commented Sep 22, 2017

I pinged others offline and the POC for coordinating a release is @mbaijal.

Another item that came up was whether to patch 0.11.0 as post-release or release a new 0.11.1. Do you foresee any problem of getting onto 0.11.1?

@fhieber
Copy link
Contributor Author

fhieber commented Sep 22, 2017

Thanks!

Actually, 11.1 / master has some nice features we would like to use asap (non-flattening FullyConnected, support for 2d input data to Sequence* operators) so we could directly upgrade to 11.1 if its released soon.

Important is the timeline for this as we currently are officially depending on 0.10.0 and the Mac pypi package seems to be removed from the index. Some people might be blocked to use Sockeye on a mac for that reason. And until 11.* pypi packages do not contain my fix, our travis builds will keep failing.

So whatever release is easier and faster would be currently preferable, but we plan upgrade to later releases faster in the future.

@szha
Copy link
Member

szha commented Sep 22, 2017

I see. @mbaijal please coordinate and come up with a timeline.

@fhieber a channel for quick integration testing is through nightly pip-release, which can be obtained through turning on --pre flag when doing pip install, just to make sure you're aware.

@fhieber
Copy link
Contributor Author

fhieber commented Sep 25, 2017

That's good to know, thank you!

@tdomhan
Copy link
Contributor

tdomhan commented Sep 27, 2017

@mbaijal any news on the timeline? :)

@mbaijal
Copy link
Contributor

mbaijal commented Sep 27, 2017

@tdomhan
Apologies for the delay in my response. The team is currently in discussions regarding the next release and I will update you as soon as we have a final timeline (I believe it should be sometime in October). In the meantime, is it possible for you to continue to use the master branch?

@tdomhan
Copy link
Contributor

tdomhan commented Sep 28, 2017

thanks for the update! Do you mean that 11.1 will be released some time in October, or that a patched version of 11.0 will be released by then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants