This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
add shared storage in windows #8967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Dec 6, 2017
| @@ -52,7 +52,7 @@ class ConnectionWrapper(object): | |||
| NDArray via shared memory.""" | |||
|
|
|||
| def __init__(self, conn): | |||
| self.conn = conn | |||
| self._conn = conn | |||
There was a problem hiding this comment.
getattr is dead cycle call. change the name same time.
piiswrong
reviewed
Dec 6, 2017
| @@ -91,11 +95,18 @@ class CPUSharedStorageManager final : public StorageManager { | |||
| private: | |||
| static constexpr size_t alignment_ = 16; | |||
|
|
|||
| std::mutex mutex_; | |||
| std::recursive_mutex mutex_; | |||
piiswrong
reviewed
Dec 6, 2017
| std::unordered_map<void*, Storage::Handle> pool_; | ||
| #ifdef _WIN32 | ||
| std::unordered_map<void*, Storage::Handle> is_free_; | ||
| std::unordered_map<void*, HANDLE> map_handle_map_; |
There was a problem hiding this comment.
why do you need two more maps?
There was a problem hiding this comment.
only use pool_ has the problem of repeated release.
|
Could you rebase? |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* add shared storage in windows * fix * lint * fix * fix * fix * fix process.h
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* add shared storage in windows * fix * lint * fix * fix * fix * fix process.h
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Essentials
make lint)