[Make] add -Werror, warnings as errors #9398
Conversation
|
I think there are a lot of warnings still to fix, until they can be treated as errors. |
|
I think I'd prefer to turn on USE_DEV=1 for some of these builds in order to fail the clang builds when the detect some warnings. I was planning on doing that and opening a PR that would address the warnings at the same time. |
| @@ -53,7 +53,7 @@ include mshadow/make/mshadow.mk | |||
| include $(DMLC_CORE)/make/dmlc.mk | |||
|
|
|||
| # all tge possible warning tread | |||
| WARNFLAGS= -Wall -Wsign-compare | |||
| WARNFLAGS= -Wall -Wsign-compare -Werror | |||
There was a problem hiding this comment.
This is something that would need to be discussed on dev. Also, when developing, you don't want to have errors on warnings
|
Thanks for the comments, I wanted to see how bad it is by running this through CR, I'm fixing warnings all the time which sometimes cover bugs. I would like to have no warnings in one or two platforms at least. As indicated by some of you, we can discuss on dev@ |
|
closing until it’s discussed in the community |
No description provided.