Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Backport gcc4 compiler fix to v1.0.0 #9433

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Backport gcc4 compiler fix to v1.0.0 #9433

merged 1 commit into from
Jan 22, 2018

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jan 15, 2018

Change the initialization for default constructor to avoid using explicit constructor (#8854)

See #8169

@cbalioglu
Copy link
Contributor

Why not just
template<> std::unordered_set<std::string> OperatorTune<__typ$>::operator_names_{} (C++11)
or
template<> std::unordered_set<std::string> OperatorTune<__typ$>::operator_names_() (C++98)?

@cjolivier01
Copy link
Member

I've had similar problems with some versions of gcc. I found ({}) to be the best way in operator_tun.cc -- I remember trying other variations, but sometimes it wouldn't create the static variable at all.

@piiswrong piiswrong merged commit 790ed30 into apache:v1.0.0 Jan 22, 2018
@leezu leezu deleted the v1.0.0 branch August 27, 2018 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants