This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Prep script and Fixes for single shot detector (SSD) #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,6 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Do we have a standard for headers? It'd be great if we could follow a convention for what to put here.
There was a problem hiding this comment.
Would be great. As far as I know this is the recommended best practice.
KellenSunderland
approved these changes
Jan 19, 2018
zhreshold
reviewed
Jan 19, 2018
| @@ -51,7 +51,9 @@ __device__ void CalculateOverlap(const DType *a, const DType *b, DType *iou) { | |||
| } | |||
|
|
|||
| template<typename DType> | |||
| __global__ void DetectionForwardKernel(DType *out, const DType *cls_prob, | |||
| __global__ | |||
| __launch_bounds__(cuda::kMaxThreadsPerBlock) | |||
There was a problem hiding this comment.
Can you explain why Volta need this?
There was a problem hiding this comment.
Kernel will fail to launch, too many resources.
yuxiangw
pushed a commit
to yuxiangw/incubator-mxnet
that referenced
this pull request
Jan 25, 2018
* data, model and demo download script for ssd example * add __launch_bounds__ to multibox_detection kernel to prevent launch failure on volta
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* data, model and demo download script for ssd example * add __launch_bounds__ to multibox_detection kernel to prevent launch failure on volta
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* data, model and demo download script for ssd example * add __launch_bounds__ to multibox_detection kernel to prevent launch failure on volta
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix multibox detector kernel resource limit on launch on volta using launch_bounds
Checklist
Essentials
make lint)Changes
Comments