This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
workaround for install page display issue #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The updated page looks like this http://mxnet-doc.s3-accelerate.dualstack.amazonaws.com/PR-9902/install/index.html. Unfortunately I haven't figured out how to try the version dropdown in a local build yet. |
|
@aaronmarkham Have you tried to directly pull https://github.com/apache/incubator-mxnet-site and debug locally? This can help you locate the issue more easily. |
|
Merging as a workaround. A proper fix should be submitted asap |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the versions dropdown on the install page when the dropdown is being injected. This is a temporary workaround while we can find a better solution for the display problems.
Background
The versions dropdown is injected in post build processing and this step breaks the page causing the wrong divs to be displayed.