Nosig armv7 #306
Merged
Nosig armv7 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkiiskila
approved these changes
Jun 7, 2017
| #define LED_BLINK_PIN (0x1) | ||
|
|
||
| /* UART info */ | ||
| #define CONSOLE_UART "uart0" |
There was a problem hiding this comment.
Dont' forget to remove this line, and the other one in native-mips bsp when pull request #314 gets merged.
ccollins476ad
added a commit
that referenced
this pull request
Jun 8, 2017
Merge remote-tracking branch 'ccollins476ad/nosig-armv7' * ccollins476ad/nosig-armv7: native-*: Remove obsolete CONSOLE_UART definitions MYNEWT-770 Use sim package in native-mips BSP. MYNEWT-770 Use sim package in native-armv7 BSP. MYNEWT-770 Use sim package in native BSP. MYNEWT-770 Separate sim package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this change is summarized in https://issues.apache.org/jira/browse/MYNEWT-770
Regarding implementation, I decided on the following:
@apache-mynewt-core/kernel/sim. This package contains the "signals" and "no-signals" implementations of the simulator.native-armv7andnative-mipsThis solution comes with a few annoyances:
kernel/os/src/arch/sim.../os_arch.cfiles. These functions just call into functions defined in thekernel/simpackage.I still think this is the right approach. Conceptually, each of these platforms is indeed a different BSP. The wrapper functions are a bit annoying, but I think it is good to keep the sim implementation as a separate module rather than finding a way to force shared code into architecture-specific source directories. However, I am definitely open to comments or suggestions.