Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-146] New Apache NetBeans Logo #447

Merged
merged 1 commit into from Mar 16, 2018
Merged

[NETBEANS-146] New Apache NetBeans Logo #447

merged 1 commit into from Mar 16, 2018

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 10, 2018

As recently voted in the Apache NetBeans mailing lists.
Notes:

  • For historic reasons, some files were originally named as ".gif" but the content was ".png" instead. I'm keeping the "gif" extensions although the content is PNG.
  • The ".ico" files for Windows have not been tested on Windows.
  • The ".icns" files for OS/X were generated in OS/X, but were not tested there.

@vieiro
Adding new Apache NetBeans Logo
2773da6 
Adding OSX .icns and Windows .ico versions

Adding ide.branding/core.startup images

Missing release/netbeans.png and release/netbeans.icns
matthiasblaesing
matthiasblaesing approved these changes Mar 11, 2018
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you!

mcdonnell-john
mcdonnell-john approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@mcdonnell-john mcdonnell-john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mac osx and looks very well

@geertjanw
Copy link
Member

All right, let’s merge.

@geertjanw geertjanw merged commit 747bbe4 into apache:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@mcdonnell-john mcdonnell-john mcdonnell-john approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vieiro @geertjanw @matthiasblaesing @mcdonnell-john