[NETBEANS-721] Jigsaw module system must be initialized in javac befo… #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re touching elements - using ELEMENTS_RESOLVED instead of PARSED as a target phase.
jlahoda
commented
May 5, 2018
| @@ -104,7 +104,7 @@ public Problem preCheck() { | |||
|
|
|||
| @Override | |||
| protected Problem preCheck(CompilationController javac) throws IOException { | |||
| javac.toPhase(JavaSource.Phase.PARSED); | |||
| javac.toPhase(JavaSource.Phase.ELEMENTS_RESOLVED); | |||
There was a problem hiding this comment.
This is the change that fixes the problem - the rest is only test and support for tests.
|
Any reason not to merge this, any reviews expected? Otherwise I will merge 24 hours from now. |
|
OK, merging. |
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
May 23, 2018
…re touching elements - using ELEMENTS_RESOLVED instead of PARSED as a target phase. (apache#534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re touching elements - using ELEMENTS_RESOLVED instead of PARSED as a target phase.