Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-491] hide progress bar from Report Problem dialog #539

Merged

Conversation

rtaneja1
Copy link
Contributor

@rtaneja1 rtaneja1 commented May 7, 2018

Also reduced the height of dialog as there was some empty space between text displayed and buttons below.

@jkovalsky
Copy link
Contributor

Why don't we simply comment out jpb.setVisible(true); at line 2380 or remove the jpb declaration completely? Do we need that progress bar for anything now that we don't communicate with any NetBeans Statistics server?

@rtaneja1
Copy link
Contributor Author

rtaneja1 commented May 7, 2018

https://issues.apache.org/jira/secure/attachment/12922249/before_report_problem.png
When we click on Review and Report Problem button, above dialog is displayed with progress bar before either error page or exception report UI is displayed (based on whether there's a submit button in form on the page pointed by ERROR_URL.) This progress bar is required for above dialog.

@jkovalsky
Copy link
Contributor

OK, if the progress bar shows progress when connecting to the ERROR_URL it probably makes sense.

@geertjanw
Copy link
Member

Thanks, merging.

@geertjanw geertjanw merged commit cd92425 into apache:master May 8, 2018
Chris2011 pushed a commit to Chris2011/netbeans that referenced this pull request May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants