[NETBEANS-953] Profiling jdk10 remote target missing conditional branch

[dellgreen]

Jdk10 as remote target seems not to be supported when profiling in netbeans9

[geertjanw]

To me, looks good, pity we won't have this in 9.0, unless a new vc will need to be made. Anyway, is there any reason why this should not be merged? Thanks for the investigation and time you must have needed to identify this problem in the code.

[dellgreen]

sure no problem, It must be stressed that, this is the first time i have submitted a patch for Netbeans, and hence not familiar with the Netbean's source code as a whole. This patch was just to allow my team to continue with its evaluation of Netbeans 9 with our existing embedded java products. However if you are happy with it, then I see no reason why it can't be merged

[geertjanw]

Very nice, thanks. More incisive pull requests such as this are more than welcome.

[emilianbold]

I think we will make another vote candidate (9.0.1?) immediately after the 9.0 release to include this too.

It's sad the Apache process takes so much time (3+ days for PPMC vote another 3+ days for IPMC vote -- there goes a full week minimum for any fix). I guess this was the reason this PR was not included: we already started a vote and would have had to start over to include it...

[geertjanw]

Yup.

And your idea for making another vote candidate asap after the 9.0 release with various pull requests, such as this one, sounds great. On the other hand, we also have the idea of a new release every three months, so, well, anyway, we can discuss this on the dev mailing list rather than here.