Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-54] Module Review editor.settings.lib - Added Apache License #66

Merged
merged 1 commit into from Oct 7, 2017

Conversation

subhash-koganti
Copy link
Contributor

  • no external libraries
  • checked Rat report and found 11 XML files that don't have any license info defined on them. Added the license text on to them .
  • After adding the text , Recompiled the code and ran the rat report again and Made sure that these files are fixed in the rat report .
  • skimmed through the module, did not notice any additional problems

@junichi11
Copy link
Member

Thanks for fixing it.

BTW, You should create a new branch, then commit your changes. maybe, since next time?

@subhash-koganti
Copy link
Contributor Author

sure sounds good.I am new to the group. Not sure what the process was. I was told to do a fork . But if Branching is the process , I will branch it next time. By the way is there a document where this is specified ?

@junichi11
Copy link
Member

Probably, There is no document about it in the wiki. I think there is no problem even if a new branch is not created. But you may get a problem in your repository after your PR is merged. e.g. If your commits are rebased then merged in the upstream repository, the upstream repository has the different commit id from your one. To keep the master branch up-to-date with the upstream repository, I recommend that you use it :)

@asfgit asfgit merged commit da72fc1 into apache:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants