Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-305: Refactoring base class from MergeContent to allow more binning processors #12

Merged
merged 3 commits into from Feb 2, 2015
Merged

Conversation

gresockj
Copy link
Contributor

Pulled out the binning logic from MergeContent into a superclass for binning processors. Basically all of the min/max properties were moved to BinFiles. Mostly focused on ensuring that the functionality was preserved from MergeContent, but there is certainly room for improvement in producing a more elegantly extensible class.

@asfbot
Copy link

asfbot commented Jan 29, 2015

Joe Gresock on dev@nifi.incubator.apache.org replies:
Mark, thanks for the feedback. Good call with the final methods -- I'll
submit another commit with those changes. As for your second point, it
sounds like a good path forward -- I'll leave it to you to cherry-pick and
place appropriately in the project hierarchy.
ally
as I=E2=80=99m
extended. This is
=9D principle that
ut you are
bably add
I don=E2=80=99t
rs
i
s
=80=8E, =E2=80=8E2015 =E2=80=8E6=E2=80=8E:=E2=80=8E01=E2=80=8E =E2=80=8EPM
o
d
ng
ur
e
se

@asfgit asfgit merged commit 615794e into apache:develop Feb 2, 2015
JPercivall pushed a commit to JPercivall/nifi that referenced this pull request Apr 23, 2018
…icate with the bootstrap process to provide an opportunity for shutdown of components.

This closes apache#12
amcdonaldccri pushed a commit to amcdonaldccri/nifi that referenced this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants