Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-280 take two #14

Closed
wants to merge 5 commits into from
Closed

Conversation

danbress
Copy link

Second try and NIFI-280's merge request. Squashed my commits. Hopefully this time works better

danbress added 3 commits January 31, 2015 09:02
@asfbot
Copy link

asfbot commented Feb 2, 2015

Mark Payne on dev@nifi.incubator.apache.org replies:
Dan=2C
Looked over this contribution. Excellent work here - will make all of our l=
ives much easier! :)
Only thing I'm really unsure about here is when you are generating HTML=2C =
you are including the Apache header into the generated HTML page and I'm no=
t sure that it should go in there.
If it were a document that went into our CM it would definitely need it. Ho=
wever=2C this is something that is getting auto-generated by NiFi at runtim=
e=2C and it would be adding Apache License headers to documentation for com=
ponents that are not part of Apache NiFi.
Can anyone confirm that I am correct here=2C that it doesn't need to be in =
the artifacts that NiFi generates at runtime or otherwise correct me if I'm=
wrong?
Thanks-Mark
ully this time works better
ting
s relevent information
your
e
please
=

@asfbot
Copy link

asfbot commented Feb 2, 2015

Joe Witt on dev@nifi.incubator.apache.org replies:
Mark,

I believe you have it correct. Headers are not required on generated
items. They are required on all source files with 'few exceptions'[1].

As long as these HTML documents are being built during the build phase that
makes them not part of the source. Remember the official release of apache
nifi are the source materials. The resulting binaries are not the
releasable item as they are not 'open source'.

[1] http://www.apache.org/legal/src-headers.html#faq-exceptions

Anyone think I have this wrong?

Thanks
Joe

@danbress
Copy link
Author

danbress commented Feb 2, 2015

Mark/Joe,
Unless I hear anything to the contrary, I'll update the code to remove the license generation later tonight.

Thanks!

Dan

@danbress
Copy link
Author

danbress commented Feb 3, 2015

Just pulled out the license generation. Let me know if there are any other problems. Thanks!

@danbress danbress closed this Feb 7, 2015
JPercivall pushed a commit to JPercivall/nifi that referenced this pull request Apr 23, 2018
…otifiers are not closed on configuration changes.

This closes apache#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants