-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket/SOL: sync the SOL index with linux #1291
Conversation
Change-Id: I32b9eb7cc3bc1428f0ff7bf5e60d7fff52621db2 Signed-off-by: chao.an <anchao@xiaomi.com>
@PetervdPerk-NXP Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, psock_getsockopt works with a switch case so shouldn't pose any problems.
@anchao is there any benefit to be "sync" with linux? |
i suspect dense numbers are easier for compilers to optimize switch statements. |
Unsynchronized options will cause some compatibility issues,
this option configure will be failure since IPPROTO_IP and SOL_IP are different definitions in NuttX, |
ok. sync with IPPROTO_ makes sense. |
Done, please help to review the following PR: |
LGTM |
Summary
socket/SOL: sync the SOL index with linux
Testing
CI check is enough